Allow global var-via-eval be declared

See tc39/ecma262#3226
tc39 · Apr 12, 2024 · c5a8099 · c5a8099
1 parent 046dff4
commit c5a8099
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 55 deletions.
diff --git a/test/annexB/language/eval-code/direct/script-decl-lex-collision-in-sloppy-mode.js b/test/annexB/language/eval-code/direct/script-decl-lex-collision-in-sloppy-mode.js
diff --git a/...t-decl-lex-no-collision-in-strict-mode.js → ...de/direct/script-decl-lex-no-collision.js b/...t-decl-lex-no-collision-in-strict-mode.js → ...de/direct/script-decl-lex-no-collision.js
@@ -2,16 +2,28 @@
 // This code is governed by the BSD license found in the LICENSE file.
 /*---
 esid: sec-globaldeclarationinstantiation
-description: No let binding collision with existing var declaration due to strict-mode eval().
+description: No let binding collision with existing var declaration due to eval().
 info: |
+  In strict mode:
+
   PerformEval ( x, strictCaller, direct )
 
   [...]
   16. If direct is true, then
     a. Let lexEnv be NewDeclarativeEnvironment(runningContext's LexicalEnvironment).
   [...]
   18. If strictEval is true, set varEnv to lexEnv.
-flags: [onlyStrict]
+
+  In sloppy mode:
+
+  GlobalDeclarationInstantiation ( script, env )
+
+  [...]
+  3. For each element name of lexNames, do
+    a. If env.HasLexicalDeclaration(name) is true, throw a SyntaxError exception.
+    b. Let hasRestrictedGlobal be ? env.HasRestrictedGlobalProperty(name).
+    c. NOTE: Global var and function bindings (except those that are introduced by non-strict direct eval) are non-configurable and are therefore restricted global properties.
+    d. If hasRestrictedGlobal is true, throw a SyntaxError exception.
 ---*/
 
 eval('if (true) { function test262Fn() {} }');

diff --git a/test/language/global-code/script-decl-lex-var-declared-via-eval-sloppy.js b/test/language/global-code/script-decl-lex-var-declared-via-eval-sloppy.js
diff --git a/...-decl-lex-var-declared-via-eval-strict.js → .../script-decl-lex-var-declared-via-eval.js b/...-decl-lex-var-declared-via-eval-strict.js → .../script-decl-lex-var-declared-via-eval.js
@@ -2,16 +2,28 @@
 // This code is governed by the BSD license found in the LICENSE file.
 /*---
 esid: sec-globaldeclarationinstantiation
-description: No let binding collision with existing var declaration due to strict-mode eval().
+description: No let binding collision with existing var declaration due to eval().
 info: |
+  In strict mode:
+
   PerformEval ( x, strictCaller, direct )
 
   [...]
   16. If direct is true, then
     a. Let lexEnv be NewDeclarativeEnvironment(runningContext's LexicalEnvironment).
   [...]
   18. If strictEval is true, set varEnv to lexEnv.
-flags: [onlyStrict]
+
+  In sloppy mode:
+
+  GlobalDeclarationInstantiation ( script, env )
+
+  [...]
+  3. For each element name of lexNames, do
+    a. If env.HasLexicalDeclaration(name) is true, throw a SyntaxError exception.
+    b. Let hasRestrictedGlobal be ? env.HasRestrictedGlobalProperty(name).
+    c. NOTE: Global var and function bindings (except those that are introduced by non-strict direct eval) are non-configurable and are therefore restricted global properties.
+    d. If hasRestrictedGlobal is true, throw a SyntaxError exception.
 ---*/
 
 eval('var test262Var;');