Normative: Make ZonedDateTime.toLocaleString work without DateTimeFormat #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2522 +/- ##
==========================================
+ Coverage 95.97% 96.16% +0.18%
==========================================
Files 20 20
Lines 11120 11121 +1
Branches 2124 2137 +13
==========================================
+ Hits 10672 10694 +22
+ Misses 387 366 -21
Partials 61 61
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
justingrant
approved these changes
Mar 21, 2023
sffc
approved these changes
Mar 21, 2023
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Apr 10, 2023
In tc39/proposal-temporal#2522 which reached consensus at the March 2023 TC39 meeting, the functionality of Temporal.ZonedDateTime.p.toLocaleString was changed substantially, to not directly pass the ZonedDateTime to any Intl.DateTimeFormat methods. This adds rewrites of all existing tests for toLocaleString, as well as a few tests to verify that Intl.DateTimeFormat methods no longer support Temporal.ZonedDateTime arguments. As we are rewriting the tests anyway, this also ports all of the Temporal.ZonedDateTime.p.toLocaleString tests that were in staging, to the correct format for the main tree.
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Apr 10, 2023
In tc39/proposal-temporal#2522 which reached consensus at the March 2023 TC39 meeting, the functionality of Temporal.ZonedDateTime.p.toLocaleString was changed substantially, to not directly pass the ZonedDateTime to any Intl.DateTimeFormat methods. This adds rewrites of all existing tests for toLocaleString, as well as a few tests to verify that Intl.DateTimeFormat methods no longer support Temporal.ZonedDateTime arguments. As we are rewriting the tests anyway, this also ports all of the Temporal.ZonedDateTime.p.toLocaleString tests that were in staging, to the correct format for the main tree.
|
Test262 tests are in tc39/test262#3814, please have a look at those as well if you have time! |
sffc
reviewed
Apr 10, 2023
justingrant
approved these changes
Apr 11, 2023
Ms2ger
pushed a commit
to ptomato/test262
that referenced
this pull request
Apr 11, 2023
In tc39/proposal-temporal#2522 which reached consensus at the March 2023 TC39 meeting, the functionality of Temporal.ZonedDateTime.p.toLocaleString was changed substantially, to not directly pass the ZonedDateTime to any Intl.DateTimeFormat methods. This adds rewrites of all existing tests for toLocaleString, as well as a few tests to verify that Intl.DateTimeFormat methods no longer support Temporal.ZonedDateTime arguments. As we are rewriting the tests anyway, this also ports all of the Temporal.ZonedDateTime.p.toLocaleString tests that were in staging, to the correct format for the main tree.
Ms2ger
pushed a commit
to tc39/test262
that referenced
this pull request
Apr 11, 2023
In tc39/proposal-temporal#2522 which reached consensus at the March 2023 TC39 meeting, the functionality of Temporal.ZonedDateTime.p.toLocaleString was changed substantially, to not directly pass the ZonedDateTime to any Intl.DateTimeFormat methods. This adds rewrites of all existing tests for toLocaleString, as well as a few tests to verify that Intl.DateTimeFormat methods no longer support Temporal.ZonedDateTime arguments. As we are rewriting the tests anyway, this also ports all of the Temporal.ZonedDateTime.p.toLocaleString tests that were in staging, to the correct format for the main tree.
See PR #2479 about which a consensus was not reached. This change allows Temporal.ZonedDateTime.prototype.toLocaleString to work by overriding the time zone at the time of creating an Intl.DateTimeFormat object and formatting the corresponding Temporal.Instant, but disallows calling any of the Intl.DateTimeFormat methods on a Temporal.ZonedDateTime. NOTE: The reference code does not implement the spec exactly as written. It observably modifies the options before passing them to the real Intl.DateTimeFormat constructor. The behaviour described in the spec is the correct behaviour.
|
Before merging, I should note for completeness that this normative change reached consensus at the March 2023 TC39 meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PR #2479 about which a consensus was not reached. This is a fallback solution. This change allows Temporal.ZonedDateTime.prototype.toLocaleString to work by overriding the time zone at the time of creating an Intl.DateTimeFormat object and formatting the corresponding Temporal.Instant, but disallows calling any of the Intl.DateTimeFormat methods on a Temporal.ZonedDateTime.
NOTE: The reference code does not implement the spec exactly as written. It observably modifies the options before passing them to the real Intl.DateTimeFormat constructor. The behaviour described in the spec is the correct behaviour.