Normative: Fix sign in PlainYearMonth.subtract#2002
Merged
Conversation
ptomato
added
spec-text
Collaborator
Author
|
cc @FrankYFTang |
Collaborator
Author
|
Draft until presented at TC39 |
ptomato
force-pushed
the
1863-plainyearmonth-subtract-negated
branch
from
40a38ae to
2a8f55c
Compare
Codecov Report
@@ Coverage Diff @@
## main #2002 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 19 19
Lines 10928 10928
Branches 1571 1571
=======================================
Hits 10075 10075
Misses 835 835
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Ms2ger
approved these changes
Jan 18, 2022
linusg
approved these changes
Feb 7, 2022
Collaborator
Author
|
This achieved consensus at the March 2022 TC39 plenary meeting. |
The duration has to be negated up front, otherwise the _sign_ < 0 test is wrong. No change in functionality in the polyfill, which already handled this correctly. This is already covered by tests. Closes: #1863
ptomato
force-pushed
the
1863-plainyearmonth-subtract-negated
branch
from
2a8f55c to
bd52e69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The duration has to be negated up front, otherwise the sign < 0 test is
wrong.
No change in functionality in the polyfill, which already handled this
correctly. This is already covered by tests.
Closes: #1863