Conversation
…String This sets `offsetString` to `timeZoneResult.[[OffsetString]]` and overwrites it in the next step if necessary, but the `[[TimeZoneOffsetString]]` field in the returned record uses `timeZoneResult.[[OffsetString]]` again instead of `offsetString` as intended. This change is needed to actually make the fix attempted in f6ac475 work.
Codecov Report
@@ Coverage Diff @@
## main #1799 +/- ##
=======================================
Coverage 94.86% 94.86%
=======================================
Files 19 19
Lines 10913 10913
Branches 1739 1739
=======================================
Hits 10353 10353
Misses 547 547
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Collaborator
|
Thanks. Since the change in #1749 was just approved in TC39 two days ago, I guess it is probably OK to merge this without waiting for the next TC39 meeting? I'll check. |
ljharb
approved these changes
Sep 2, 2021
justingrant
approved these changes
Sep 9, 2021
Collaborator
|
I'm going to go ahead and merge this since it correctly implements the normative change that reached consensus in TC39. |
linusg
deleted the
fix-timezoneoffsetstring-value-in-parsetemporalinstantstring
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets
offsetStringtotimeZoneResult.[[OffsetString]]and overwrites it in the next step if necessary, but the[[TimeZoneOffsetString]]field in the returned record usestimeZoneResult.[[OffsetString]]again instead ofoffsetStringas intended.This change is needed to actually make the fix attempted in f6ac475 work.