This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
[spec] Remove fallback, per 2018.11.28 TC39 feedback #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested review from
bterlson,
mathiasbynens,
littledan,
ajklein,
zenparsing and
gsathya
mathiasbynens
suggested changes
Nov 29, 2018
|
I love how close this is to https://tc39.github.io/ecma262/#sec-string.prototype.match now! |
ljharb
force-pushed
the
remove_fallback
branch
from
2159eae
to
3e17137
Compare
mathiasbynens
approved these changes
Nov 29, 2018
gsathya
approved these changes
Nov 29, 2018
|
cc @anba |
littledan
approved these changes
Dec 2, 2018
zenparsing
reviewed
Dec 7, 2018
ljharb
force-pushed
the
remove_fallback
branch
from
3e17137
to
9c9cd69
Compare
zenparsing
approved these changes
Dec 7, 2018
peterwmwong
added a commit
to peterwmwong/test262
that referenced
this pull request
Dec 9, 2018
- Changes associated with spec changes (tc39/proposal-string-matchall#41) - Update spec comments - Added test verifying error thrown when `regexp[Symbol.matchAll]` is not callable - Added test verifying `ToString` is called on `receiver`
|
LGTM! |
peterwmwong
added a commit
to peterwmwong/test262
that referenced
this pull request
Dec 10, 2018
- Changes associated with spec changes (tc39/proposal-string-matchall#41) - Update spec comments - Added test verifying error thrown when `regexp[Symbol.matchAll]` is not callable - Added test verifying `ToString` is called on `receiver`
leobalter
pushed a commit
to tc39/test262
that referenced
this pull request
Dec 10, 2018
- Changes associated with spec changes (tc39/proposal-string-matchall#41) - Update spec comments - Added test verifying error thrown when `regexp[Symbol.matchAll]` is not callable - Added test verifying `ToString` is called on `receiver`
bterlson
approved these changes
Dec 11, 2018
ljharb
added a commit
to es-shims/String.prototype.matchAll
that referenced
this pull request
Dec 12, 2018
zloirock
added a commit
to zloirock/core-js
that referenced
this pull request
Dec 12, 2018
guybedford
pushed a commit
to guybedford/v8
that referenced
this pull request
Dec 20, 2018
As per (tc39/proposal-string-matchall#41), String.p.matchAll's fallback was removed. Additionally, removed a IsNullOrUndefined check that was already covered by MaybeCallFunctionAtSymbol. Updates to Test262 has been submitted: tc39/test262#1990 Bug: v8:6890 Change-Id: I246cbbcb4641ebded704c5f772809f182deaa30e Reviewed-on: https://chromium-review.googlesource.com/c/1369091 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#58172}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39.