This repository was archived by the owner on Oct 24, 2023. It is now read-only.
Normative: Check for detached buffers before calling HostResizeArrayBuffer#123
Closed
anba wants to merge 1 commit intotc39:masterfrom
Closed
Normative: Check for detached buffers before calling HostResizeArrayBuffer#123anba wants to merge 1 commit intotc39:masterfrom
anba wants to merge 1 commit intotc39:masterfrom
Conversation
…uffer `ToIntegerOrInfinity` can detach the buffer, adding an explicit `IsDetachedBuffer` call makes it more clear which error should be thrown in that case.
Contributor
Author
|
This test throws a TypeError in V8, but a RangeError in JSC: let buffer = new ArrayBuffer(4, {maxByteLength: 8});
buffer.resize({
valueOf() {
buffer.transfer();
return 4;
}
});With the proposed change, a TypeError is expected. |
syg
reviewed
Jul 7, 2023
| @@ -276,6 +276,7 @@ <h1>ArrayBuffer.prototype.resize ( _newLength_ )</h1> | |||
| 1. If IsDetachedBuffer(_O_) is *true*, throw a *TypeError* exception. | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| 1. If IsDetachedBuffer(_O_) is *true*, throw a *TypeError* exception. |
Collaborator
There was a problem hiding this comment.
In that case, given lack of interop right now between V8 and JSC, I'd prefer to sink the detached check to be after the _newLength_ coercion. I'll add it to the agenda.
Collaborator
|
Oh actually this is just duplicated of #120. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ToIntegerOrInfinitycan detach the buffer, adding an explicitIsDetachedBuffercall makes it more clear which error should be thrown in that case.