Web compatibility issue with flickr.com (in YUI 3)

[jorendorff]

Steps to reproduce:

1. Go to https://www.flickr.com/photos/mhoye/50305446521/
2. Wait the page is fully rendered
3. Click on the arrow pointing downward on the right hand below the image.

Expected:
Show a modal popup with image size available to download

Actual:
Nothing happens.

Discovered in Firefox Nightly. We have already backed out String.prototype.item, but this problem still persists. Manually doing delete Array.prototype.item; in the JS console fixes it.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1669867.

[jorendorff]

Looks like YUI feature-testing again, but in YUI 3 this time. It happens in the implementation of Y.Node.scrubVal.

            } else if ((val.item && !val._nodes) || // dom collection or Node instance

[hax]

It's seem "reasonable" for libraries use item to detect whether an object is DOM collection, such "detection" conflict with the original motivation of this proposal (unify DOM item() method via adding item() on Array). Have no idea how this could be solved. 😥

[sdwvit]

hey can someone point me to the doc or ticket where it is explained why the * tc39 cares about breaking 3rd party libraries?

[bakkot]

@sdwvit There's a good summary by a TC39 delegate here.

[nicolo-ribaudo]

It's kind of ironic that the "Space Jam website" link in that blog post gives a "not found" error.

[rkirsling]

@nicolo-ribaudo I think the link just needs to be updated—spacejam.com does work.

(CC @mathiasbynens)

[ljharb]

https://web.archive.org/web/20190220034807/https://www.warnerbros.com/archive/spacejam/movie/jam.htm works and https://web.archive.org/web/20190309232529/https://www.warnerbros.com/archive/spacejam/movie/jam.htm doesn't; looks like warnerbros.com broke the link by converting it into an incorrect redirect sometime between 2019-02-20 and 2019-03-09 :-/

[mathiasbynens]

Looks like Warner Bros missed the memo 😢

I'll update the article.