Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explainer: Pipes with method chaining in React example #236

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

js-choi
Copy link
Collaborator

@js-choi js-choi commented Sep 28, 2021

See #213.

CC: @acutmore, @luncheon.

@tabatkins
Copy link
Collaborator

I'm neutral on this. I still find it perfectly readable with all pipes, but there's nothing wrong with doing it this way either. Maybe a mix of styles is appropriate, then? (The HTML spec does that sometimes, to intentionally indicate by example that multiple syntax styles are acceptable and none are particularly favored.)

@js-choi
Copy link
Collaborator Author

js-choi commented Sep 28, 2021

Yes, I think that, if nothing else, it demonstrates that these styles (Hack pipes and method calling) can be mixed without precedence problems. This is an advantage of Hack pipes.

@js-choi js-choi merged commit 265f2f0 into main Sep 29, 2021
@js-choi js-choi deleted the js-choi-method-chain-mix-example branch September 29, 2021 14:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants