Skip to content
This repository was archived by the owner on Oct 8, 2024. It is now read-only.

fixes #115: @@toStringTag is writable now #214

Merged
merged 4 commits into from
Sep 15, 2022
Merged

fixes #115: @@toStringTag is writable now #214

merged 4 commits into from
Sep 15, 2022

Conversation

@michaelficarra
Copy link
Member

@michaelficarra michaelficarra commented Aug 9, 2022

Fixes #115. Option 2: just make @@toStringTag writable.

@ljharb ljharb mentioned this pull request Sep 2, 2022
Closed
11 tasks
@michaelficarra
Copy link
Member Author

michaelficarra commented Sep 14, 2022

While I appreciate the thumbs-ups, I actually need an approving review here to merge.

Feedback from committee was to make this property writable.

bakkot
bakkot approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but might be worth having an explicit emu-note calling out the unusual value and the reason for it; it's not obvious that this boilerplate is different from all the other boilerplate.

@michaelficarra
just remove the exception
a42c6b6 
> Every other data property described in clauses 19 through 28 and in
> Annex B.2 has the attributes { [[Writable]]: true, [[Enumerable]]:
> false, [[Configurable]]: true } unless otherwise specified.
@michaelficarra
Copy link
Member Author

michaelficarra commented Sep 15, 2022

I've updated the PR to just remove the description of the property descriptor properties since

Every other data property described in clauses 19 through 28 and in Annex B.2 has the attributes { [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: true } unless otherwise specified.

and these @@toStringTag properties now use the default.

@michaelficarra
Copy link
Member Author

michaelficarra commented Sep 15, 2022

Per @bakkot's request, I've added a note anyway.

@michaelficarra michaelficarra merged commit 1c066c0 into main Sep 15, 2022
@michaelficarra michaelficarra deleted the GH-115-2 branch September 15, 2022 22:47
2767mr pushed a commit to 2767mr/graaljs that referenced this pull request Sep 16, 2022
Make toStringTag writable
4b8a813 
Spec change: tc39/proposal-iterator-helpers#214
2767mr pushed a commit to 2767mr/graaljs that referenced this pull request Sep 19, 2022
Make toStringTag writable
8e5fe59 
Spec change: tc39/proposal-iterator-helpers#214
@michaelficarra michaelficarra mentioned this pull request Sep 18, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bakkot bakkot bakkot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Web compat: The %Symbol.toStringTag% property on %Iterator.prototype% needs to be writable

3 participants

@michaelficarra @bakkot