toString() and normalization

[littledan]

EDIT: I seem to have misunderstood Waldemar's proposal; see #12 (comment) for clarification.

In this post, @waldemarhorwat proposed that BigDecimal.prototype.toString() (and presumably ToString applied to BigDecimal) should cut off all trailing zeroes, and not distinguish between elements of the same "cohort" (that is, decimals that have the same mathematical value, but different numbers of significant figures/trailing 0's).

One piece of motivation for Waldmar's argument is that it could be seen as surprising if arr[5m] was not the same as arr[5.000m]. But personally, I find it a little surprising if toString always discards the trailing zeros that we'd otherwise work hard to preserve. It may be semantically wrong for end users if toString() is used on BigDecimal and it cuts off trailing zeros unexpectedly.

I see a few options that we might take to square this circle:

• Just tough it out and teach people to use Intl.NumberFormat when they want trailing zeroes represented (you should probably be doing something locale-specific when displaying numbers to people anyway).
• Require that the option of whether or not to display trailing zeroes is provided to the toString algorithm, and make the ToString algorithm simply throw on BigDecimal, either through
  • Having two separate methods, BigDecimal.prototype.toStringNormalized() and BigDecimal.prototype.toStringWithTrailingZeroes(), and not have a toString() method.
  • Make the second parameter an options bag that's required to have a showTrailingZeroes option, and if it's not provided, throw.
• Tough it out the other way and just include trailing zeroes in toString(), while discouraging developers from using BigDecimal as an array index.

Thoughts?

[fabiosantoscode]

Maybe add an argument to toString much like Number's toString?

1.0n..toString(4) gives us 4 decimal places. 1.0n..toString(0) returns no decimal places.

[MaxGraey]

For Number literals 10..toString need because we have shorthands .1 or 10.. For BigInt literal and for BigDecimal we don't need this because we have "m or n prefix escaping" - 10m.toString() or 10.0m.toString().

[ljharb]

I’m confused; in this proposal, 5m and 5.00m are not the same identical number?

[MaxGraey]

As I understand 1.0m != 1.000m because count of trailing zeros indicate BigDecimal's precision. The same as 1.0_f32 can't direct compare with 1.0_f64 without explicit conversions in some languages

[ljharb]

Different types i understand; precision to me doesn’t seem like it should be part of identity.

[littledan]

@ljharb This is an interesting point; maybe you could file another issue if you want to pursue this further. This issue is about working out the semantics for toString under the assumption that BigDecimal would support trailing zeroes. As the README points out, trailing zeroes are a feature of many Decimal types, and they are important for many applications. See background in http://speleotrove.com/decimal/decifaq1.html#tzeros .

[ljharb]

I'll try to find time to file another issue for that; as for this one, if 5.0d !== 5.00d, then I'd expect String(5.0d) !== String(5.0.0d).

[littledan]

It's always possible to state more invariants. I'd like to hear your rationale.

[MaxGraey]

Java's BigDecimal has special method for comparison

[littledan]

Let's continue the comparison discussion in #11. As mentioned in that issue, I'd like to use @waldemarhorwat's proposal as a starting point for both toString() and equality semantics.

[ljharb]

My rationale is that the string representation of two different things should be different (if the toString output is going to be useful at all). If 5.0d and 5.00d are the same (===) then they should have the same string output; if different, different.

[littledan]

Waldemar's proposal was that the two BigDecimals 5.00m and 5.0m would be different values but be ===, like 0.0 and -0.0. I think that if two things are SameValue, they should be indistinguishable in their behavior.

[waldemarhorwat]

Waldemar's proposal was that the two BigDecimals 5.00m and 5.0m would be different values but be ===, like 0.0 and -0.0.

No, my proposal was not that that example (or, for even more fun, 6m-6m and 16m-16m) be different values. I want them to be the same. It's clear that they must be ===. They should be indistinguishable as well.