WebCompat regressions with `group`

[codehag]

Hey all,

We have another regression, this time with group. https://bugzilla.mozilla.org/show_bug.cgi?id=1791415#c14

It didn't get surfaced quite as quickly as the last one, as it was harder to catch. This may be true of other sites.

[codehag]

I think if this is unique to last pass, we may be able to have them update. However, given how hard it was to catch, this might be failing silently elsewhere? I wonder if we need to have a usage counter for this before moving forward with shipping?

[ljharb]

Any idea what code on LastPass is breaking with this?

[syg]

@codehag Was https://bugzilla.mozilla.org/show_bug.cgi?id=1791415#c14 actually confirmed to fix the issue?

[codehag]

Looks like not yet, still waiting on the full picture.

[codehag]

We have a second regression that appears to be related to this proposal: https://bugzilla.mozilla.org/show_bug.cgi?id=1799522 / webcompat/web-bugs#112923

[codehag]

And a third, unfortunately: webcompat/web-bugs#112552 -- also tested and confirmed on chrome canary.

[syg]

In light of these discovered incompatibilities Chrome will no longer be shipping this proposal in 108.

[neclimdul]

I haven't tested the proposed removal but Array.prototype.group = null; in the console did fix my LastPass extension. Several traces are also in the bugzilla issue that point to the group property/method.

[neclimdul]

Since LastPass isn't the only regression I doubt it matters to much but some additional information. I regularly use LastPass with the same account in Chrome unstable and haven't run into the same problem. I can confirm the other regressions from this issue on that browser so the so probably a frustrating variation between the Chrome and Firefox extension provided by LastPass.

[bricss]

Maybe, it might be possible to rename group() and groupToMap() into assort() and assortToMap() and ship 🚢 it asap 🤔

[ljharb]

I’m not familiar with any such word “assort” - that may not be an intuitive option.

[bricss]

That's what I found in dictionary for group synonyms 😀 sounds legit, imo 🙄

[lilnasy]

Safari 16.4 shipped Array#group. At the time, this broke IBM cloud login (webcompat/web-bugs#112923), but not altron.ch (webcompat/web-bugs#112552). IBM's usage involved treating an array as a query param object, one of the keys of which was group. They seem to have corrected this misuse since then.

[bricss]

Shall we also break things and move fast ⏩ forward? 😀

[o-t-w]

It's already stable Safari and all the other naming suggestions are terrible.

[bathos]

I guess this is where we're bikeshedding backup names.

• bucket
• keyBy
• toGroups
• switch kidding

I’m not familiar with any such word “assort” - that may not be an intuitive option.

It’s a pity this is too obscure because I think it'd be a semantic upgrade from “group” if not for that — it implies grouping on the basis of some condition, not just arbitrary grouping.

[karlcow]

• arrangeBy https://github.com/search?q=arrangeby+language%3AJavaScript&type=code
• bucket https://github.com/search?q=bucket+language%3AJavaScript&type=code
• keyBy https://github.com/search?q=keyby+language%3AJavaScript&type=code
• toGroups https://github.com/search?q=toGroups+language%3AJavaScript&type=code
• groupToObject https://github.com/search?q=groupToObject+language%3AJavaScript&type=code

etc. all names need to be checked against what exist out there.

[ljharb]

I don't think we need additional name suggestions right now; we're right in the middle of the TC39 plenary and we'll be discussing it further tomorrow.

[ljharb]

The proposal has been demoted to stage 2, with the expectation that I will be requesting stage 3 for it in July with static methods (#47).