refactor: Copy Array.from’s array-like loop #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes use of %Array.prototype.values%. Closes #29. Maybe in the future we can come back to this and simplify both Array.from and Array.fromAsync with %Array.prototype.values%. Because we haven’t confirmed that this is truly unobservable, today is not that day.
ljharb
approved these changes
Jul 20, 2022
|
Perhaps there is a common AO between Array.from and Array.fromAsync, but, since that’d be an editorial change, we can do that in a separate Ecma262 pull request after this proposal gets Stage-4 merged. (And I’m still holding out hope for the %Array.prototype.values% simplification being unobservable…) |
js-choi
added
bug
zloirock
added a commit
to zloirock/core-js
that referenced
this pull request
Sep 15, 2022
…array-like branch of `Array.fromAsync` tc39/proposal-array-from-async#30
zloirock
added a commit
to zloirock/core-js
that referenced
this pull request
Oct 6, 2022
…array-like branch of `Array.fromAsync` tc39/proposal-array-from-async#30
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes use of %Array.prototype.values%.
Closes #29. Also affects #14.
Maybe in the future we can come back to this and simplify both Array.from and Array.fromAsync with %Array.prototype.values%. Because we haven’t confirmed that this is truly unobservable, today is not that day.