Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Copy Array.from’s array-like loop #30

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Conversation

js-choi
Copy link
Collaborator

@js-choi js-choi commented Jul 20, 2022

Removes use of %Array.prototype.values%.
Closes #29. Also affects #14.
Maybe in the future we can come back to this and simplify both Array.from and Array.fromAsync with %Array.prototype.values%. Because we haven’t confirmed that this is truly unobservable, today is not that day.

Removes use of %Array.prototype.values%.
Closes #29.
Maybe in the future we can come back to this and simplify both Array.from and Array.fromAsync with %Array.prototype.values%. Because we haven’t confirmed that this is truly unobservable, today is not that day.
@js-choi js-choi added the help wanted Extra attention is needed label Jul 20, 2022
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps there's a common AO that both Array.from and Array.fromAsync could share?

@js-choi
Copy link
Collaborator Author

js-choi commented Jul 21, 2022

Perhaps there is a common AO between Array.from and Array.fromAsync, but, since that’d be an editorial change, we can do that in a separate Ecma262 pull request after this proposal gets Stage-4 merged. (And I’m still holding out hope for the %Array.prototype.values% simplification being unobservable…)

@js-choi js-choi merged commit 15ceae3 into main Aug 17, 2022
@ljharb ljharb deleted the separate-array-likes branch August 17, 2022 14:54
@js-choi js-choi added bug Something isn't working and removed help wanted Extra attention is needed labels Aug 17, 2022
zloirock added a commit to zloirock/core-js that referenced this pull request Sep 15, 2022
zloirock added a commit to zloirock/core-js that referenced this pull request Oct 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using %Array.prototype.values%
2 participants