-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✅ add test for ideal TLAs #274
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really necessary? I don't think we need to be failing CI over this. And I expect it will have a pretty high false-positive rate. Overall, doesn't seem worth it.
We are a global organization so it seems less ideal to codify rules depending on the existence of a single first name and single last name - see Falsehoods Programmers Believe About Names |
necessary is a strong word, but this has been a recurring problem with folks creating TLA PRs and it takes the chairs an inordinate amount of time and extended feedback loops to resolve. the point of this PR is to improve the process, catch problems and reduce the burden overall. an alternative could be to just move the TLA PR onboarding item into the 'chair tasks' portion of onboarding -- and it's something we often already do anyway. edit: but chairs can, and do, still make mistakes, so these checks are still useful. edit:
agree -- I hope my above comments clear this up. this isn't about drawing lines in the sand, only about trying to better adhere to our convention and avoid mistakes. |
Got it, I understand the motivation. In that case, how important is it that this particular convention be followed? As long as people put their abbreviations in their video chat names, and on their nameplates when in person... can't we just allow any TLA that is reasonably associated with the delegate's full name, and cut out the extra work for the chairs that way? |
this is a fair question and one that I can't answer definitively. one of the biggest reasons for the convention is so that when people taking notes are doing attribution, if they don't have all the TLAs memorized, they can reasonably infer based on the convention. e.g. if they see Rob Palmer is talking, that will infer to be clear, there is nothing with this PR that says we can't add new exceptions to the convention; it's only to make it so that this is done deliberately and not accidentally. this PR doesn't change the convention nor does it change anything about following or not following the convention. |
If we want to reform acronyms of people, I'd rather focus on moving people with two-letter acronyms to three-letter ones, so we aren't encoding this irrelevant seniority information. This patch goes in the opposite direction, making an additional marker of semi-seniority for people with irregular TLAs. I prefer our system of letting people choose whatever TLA they want. |
that's not what we're doing here
that's not the intent here, please see this comment
that's not entirely accurate -- we steer toward the convention if available |
If this is the problem we are trying to solve, can we instead force people (both remote, in the zoom name, and in person, on a piece of paper), to explicitly write their acronym? Even to the point of only letting people speak if they have the acronym spelled out. This would be incredibly more helpful than asking note takers to infer the acronym based on the name, since note taking is already a demanding task and we should try to reduce the cognitive overload, not to increase it. |
It's my fault for not including an explainer when I opened this PR, but the intent of this has been misunderstood and my attempts at clarification seem to have been inadequate. This PR is not about changing anything, reforming anything, or doing anything different from the status quo. It is simply to call attention to potential issues to reduce the incidence of human error -- which is the same point of the existing tests. We can assess the merits of the test and my thinking is that, if this is merged and then becomes clear it is not worth having, then we can simply remove it. Issues regarding the TLA convention, improving outcomes for note-taking during meetings, and other aspects that have been brought up are all valid and are fair game for discussion, but are beyond the scope of this PR. Those topics would be better served via issues in Reflector. |
6e76a9a
to
832ec8f
Compare
No description provided.