Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "function coloring" to glossary #155

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Add "function coloring" to glossary #155

merged 2 commits into from
Oct 10, 2024

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Oct 8, 2024

No description provided.

@bakkot bakkot requested a review from rkirsling October 8, 2024 15:42
rkirsling
rkirsling approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@rkirsling rkirsling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

ljharb
ljharb reviewed Oct 9, 2024
View reviewed changes
terminology.md Show resolved Hide resolved
@bakkot @ljharb
Update terminology.md
98a1a5c 
Co-authored-by: Jordan Harband <ljharb@gmail.com>
michaelficarra
michaelficarra approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't love the spelling of colouring, but LGTM.

syg
syg approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on god i will disapprove this if it's spelled "colouring"

@bakkot bakkot merged commit 49cb9e9 into main Oct 10, 2024
2 checks passed
@bakkot bakkot deleted the bakkot-patch-1 branch October 10, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@syg syg syg approved these changes

@michaelficarra michaelficarra michaelficarra approved these changes

@rkirsling rkirsling rkirsling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bakkot @ljharb @syg @michaelficarra @rkirsling