Skip to content

Unify and improve cancellation buttons#696

Merged
michaelficarra merged 4 commits into
tc39:mainfrom
gibson042:2026-05-cancellation-controls
Jul 7, 2026
Merged

Unify and improve cancellation buttons#696
michaelficarra merged 4 commits into
tc39:mainfrom
gibson042:2026-05-cancellation-controls

Conversation

@gibson042

@gibson042 gibson042 commented May 3, 2026

Copy link
Copy Markdown
Member

(relating to pinned links and the references pane)

  • make unpin buttons less rigid about event.target and more compatible with DOM modifications
  • make the "references-pane-close" element an actual button
  • add a generic "cancellation-button" class for the text content
  • consistently apply border/background/color/cursor defaults with hover overrides as appropriate
  • use the actual cancellation character for cancellation buttons (U+2716 HEAVY MULTIPLICATION X "" → U+1F5D9 CANCELLATION X "")

@gibson042
gibson042 requested review from bakkot and michaelficarra May 3, 2026 18:17
gibson042 added 3 commits July 7, 2026 13:06
...and more compatible with DOM modifications
make them all actual buttons, add a generic class for the content, and
consistently apply border/background/color/cursor defaults with hover
overrides as appropriate
@michaelficarra
michaelficarra force-pushed the 2026-05-cancellation-controls branch from 2bcc7ac to 9bf8b1e Compare July 7, 2026 19:06
@michaelficarra

Copy link
Copy Markdown
Member
  • use the actual cancellation character for cancellation buttons (U+2716 HEAVY MULTIPLICATION X "✖" → U+1F5D9 CANCELLATION X "🗙")

GitHub renders this glyph with "Apple Color Emoji", which looks like this:

image

And I don't think our distribution of IBM Plex will have this glpyh. So I don't think we can make this change.

macOS and IBM Plex fonts don't have a good glyph for U+1F5D9 CANCELLATION X
@gibson042

gibson042 commented Jul 7, 2026

Copy link
Copy Markdown
Member Author
  • use the actual cancellation character for cancellation buttons (U+2716 HEAVY MULTIPLICATION X "" → U+1F5D9 CANCELLATION X "")

GitHub renders this glyph with "Apple Color Emoji", which looks like this:

image

And I don't think our distribution of IBM Plex will have this glpyh. So I don't think we can make this change.

Ugh, confirmed. I've reverted back to U+2716 HEAVY MULTIPLICATION X "✖" so we can pick up the other changes. We could also use U+274C CROSS MARK "❌", but that renders as emoji by default and not all (browser, OS) pairs allow overriding that with text presentation "❌︎" so we'd likely want more discussion before adopting it.

@gibson042 gibson042 mentioned this pull request Jul 7, 2026

@michaelficarra michaelficarra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably improve a11y of these features at some point, too.

@michaelficarra
michaelficarra merged commit b695d0d into tc39:main Jul 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants