Skip to content

Normative: Adding Intl.RelativeTimeFormat specification #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 26, 2020

Conversation

caiolima
Copy link
Contributor

Adding specification text from https://github.com/tc39/proposal-intl-relative-time to the main spec.

@longlho
Copy link
Collaborator

longlho commented Nov 27, 2019

Can this wait for the remaining PRs in https://github.com/tc39/proposal-intl-relative-time to be resolved?

@ljharb ljharb added the stage 3 label Nov 27, 2019
@caiolima
Copy link
Contributor Author

Can this wait for the remaining PRs in https://github.com/tc39/proposal-intl-relative-time to be resolved?

This PR is blocked until we merge all PRs on proposal's repo. Also, it needs to wait until we get stage 4 status from TC39.

@longlho
Copy link
Collaborator

longlho commented Nov 27, 2019

thanks for the explanation!

@leobalter
Copy link
Member

@caiolima any updates since then?

@littledan
Copy link
Member

Now that Intl.RelativeTimeFormat is at Stage 4, I think this PR is good to land (modulo editor reviews).

@caiolima caiolima force-pushed the intl-relative-time-format branch from 22afab7 to 8565d80 Compare January 15, 2020 20:49
@caiolima
Copy link
Contributor Author

@caiolima any updates since then?

@leobalter just rebased it.

@leobalter leobalter removed the stage 3 label Jan 24, 2020
@leobalter leobalter requested a review from spectranaut January 24, 2020 20:10
@leobalter leobalter added the has consensus Has consensus from TC39-TG2 label Jan 24, 2020
Copy link

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few minor editorial requests before we merge this PR. Most of the work is changing the string literal format, I linked the PRs you can use as an example of what should change!

Copy link
Contributor Author

@caiolima caiolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the review

Copy link

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@leobalter leobalter merged commit c5417aa into tc39:master Feb 26, 2020
sideshowbarker added a commit to w3c/browser-compat-data that referenced this pull request Mar 4, 2020
tc39/ecma402#391 moved the RelativeTimeFormat
into the ECMA402 specification. This change updates the associated BCD
spec URLs.

tc39/ecma402@c5417aa
sideshowbarker added a commit to w3c/browser-compat-data that referenced this pull request Mar 4, 2020
tc39/ecma402#391 moved RelativeTimeFormat into
the ECMA402 spec. This change updates the associated BCD spec URLs.

tc39/ecma402@c5417aa
Elchi3 pushed a commit to mdn/browser-compat-data that referenced this pull request Mar 4, 2020
tc39/ecma402#391 moved RelativeTimeFormat into
the ECMA402 spec. This change updates the associated BCD spec URLs.

tc39/ecma402@c5417aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has consensus Has consensus from TC39-TG2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants