-
Notifications
You must be signed in to change notification settings - Fork 108
Normative: Adding Intl.RelativeTimeFormat specification #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can this wait for the remaining PRs in https://github.com/tc39/proposal-intl-relative-time to be resolved? |
This PR is blocked until we merge all PRs on proposal's repo. Also, it needs to wait until we get stage 4 status from TC39. |
thanks for the explanation! |
@caiolima any updates since then? |
Now that Intl.RelativeTimeFormat is at Stage 4, I think this PR is good to land (modulo editor reviews). |
22afab7
to
8565d80
Compare
@leobalter just rebased it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few minor editorial requests before we merge this PR. Most of the work is changing the string literal format, I linked the PRs you can use as an example of what should change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
tc39/ecma402#391 moved the RelativeTimeFormat into the ECMA402 specification. This change updates the associated BCD spec URLs. tc39/ecma402@c5417aa
tc39/ecma402#391 moved RelativeTimeFormat into the ECMA402 spec. This change updates the associated BCD spec URLs. tc39/ecma402@c5417aa
tc39/ecma402#391 moved RelativeTimeFormat into the ECMA402 spec. This change updates the associated BCD spec URLs. tc39/ecma402@c5417aa
Adding specification text from https://github.com/tc39/proposal-intl-relative-time to the main spec.