-
Notifications
You must be signed in to change notification settings - Fork 113
Normative: Add missing name property for %IntlSegmentsPrototype%[%Symbol.iterator%] #1015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…bol.iterator%] The function name must be explicitly specified for methods whose property key is a Symbol value.
gibson042
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks; I agree that this is needed.
|
The observable behavior is: s = new Intl.Segmenter()
// Segmenter {}
ss = s.segment("123")
// Segments {}
ss[Symbol.iterator].name
// '[Symbol.iterator]'The last line is the web reality that this PR makes the spec reality. |
|
Went to add this to the agenda to find it already there :D I'm happy to present it to the plenary but please do let me know if anyone else would rather do it to avoid duplicating effort. |
|
2025-07-28: This PR got TG1 approval. |
…iterator%]` https://bugs.webkit.org/show_bug.cgi?id=296801 Reviewed by NOBODY (OOPS!). This patch changes to implement tc39/ecma402#1015 * Source/JavaScriptCore/runtime/IntlSegmentsPrototype.cpp: (JSC::IntlSegmentsPrototype::finishCreation):
…iterator%]` https://bugs.webkit.org/show_bug.cgi?id=296801 Reviewed by Yusuke Suzuki. This patch changes to implement tc39/ecma402#1015 * Source/JavaScriptCore/runtime/IntlSegmentsPrototype.cpp: (JSC::IntlSegmentsPrototype::finishCreation): Canonical link: https://commits.webkit.org/298181@main
The function name must be explicitly specified for methods whose property key is a Symbol value.