Editorial: MakeMatchIndicesIndexPairArray: avoid creating a property on undefined #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd prefer to add an assertion, rather than a guard. |
|
How would you word it? That groupNames only contains strings when hasGroups is true? |
bakkot
reviewed
Mar 27, 2022
…on undefined (tc39#2714) This is currently a _potential_ spec bug, not an actual one. This AO is not called such that this would be an error, but there are no assertions to prevent it from being one.
ljharb
force-pushed
the
matchindicesarraybug
branch
from
1bcbdff
to
caa6e3f
Compare
bakkot
approved these changes
Mar 27, 2022
bakkot
added
the
ready to merge
|
Assert is fine, though the confusion here points to a possible larger refactoring around groups and groupNames to make the paths less confusing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently a potential spec bug, not an actual one. This AO is not called such that this would be an error, but there are no assertions to prevent it from being one.