-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: "a new empty List" -> "« »" #2666
Conversation
This change was actually mostly done by accident in #2547. It started by changing "Return a new Empty List" to "Return Completion(« »)" (since lists in AO arguments are written that way), and then later stripping out unneeded Completion applications to arrive at "Return « »". I'm not sure if it's a great idea to just make this change everywhere though. Let's talk about it in the editor call. |
Previously: #2201 |
For empty lists, I think:
I offer no commentary on what to do in other cases, but we should presumably default to leaving them as they are unless we are able to write down a consistent rule (which isn't necessarily worth doing). |
The rule about AO arg lists applies to non-empty lists as well. |
I've updated the PR to meet those criteria. |
Here's the current rubric as discussed for "a new empty list":
I'll update this PR to match, and to resolve the above comments. |
…o;" (tc39#2666) Rubric used: - we should use syntax consistently when in argument lists, including arguments to SDOs, for both empty and non-empty lists - when returning a new empty list from an AO/SDO, we should use prose - when initializing or defaulting an alias to an empty list, use prose - for everything else, leave as-is ("author's choice"), for now
…o;" (tc39#2666) Rubric used: - we should use syntax consistently when in argument lists, including arguments to SDOs, for both empty and non-empty lists - when returning a new empty list from an AO/SDO, we should use prose - when initializing or defaulting an alias to an empty list, use prose - for everything else, leave as-is ("author's choice"), for now
Updated; the diff is now much smaller. |
@ljharb Can you give us a sampling of the cases that could change (in either direction) but did not fall into any of the above rules? |
The remaining cases seem to be mostly "in a table", "in prose", or "in a list of key/value pairs when completing a Record", for which i went with syntax, prose, syntax, respectively. |
…o;" (tc39#2666) Rubric used: - we should use syntax consistently when in argument lists, including arguments to SDOs, for both empty and non-empty lists - when returning a new empty list from an AO/SDO, we should use prose - when initializing or defaulting an alias to an empty list, use prose - for everything else, leave as-is ("author's choice"), for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't review for completeness, but what's here LGTM
@ljharb Those seem like the choices I would make, too. We can take a look at those examples together in the next editor call to see if we can agree on further rules. |
…o;" (tc39#2666) Rubric used: - we should use syntax consistently when in argument lists, including arguments to SDOs, for both empty and non-empty lists - when returning a new empty list from an AO/SDO, we should use prose - when initializing or defaulting an alias to an empty list, use prose - for everything else, leave as-is ("author's choice"), for now
…o;" (tc39#2666) Rubric used: - we should use syntax consistently when in argument lists, including arguments to SDOs, for both empty and non-empty lists - when returning a new empty list from an AO/SDO, we should use prose - when initializing or defaulting an alias to an empty list, use prose - for everything else, leave as-is ("author's choice"), for now
Peeled this out of #2547.