Normative: add #x in obj syntax
#2290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
added
normative change
25 tasks
ljharb
force-pushed
the
private-fields-in-in
branch
from
37b4f60
to
17d9044
Compare
jmdyck
requested changes
Jan 28, 2021
ljharb
force-pushed
the
private-fields-in-in
branch
from
17d9044
to
b95c824
Compare
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Jan 28, 2021
ljharb
force-pushed
the
private-fields-in-in
branch
from
b95c824
to
3ad18be
Compare
|
I've split out all the fixes you requested that aren't part of this PR, but are instead part of #1668, into a separate commit. Please only review the last commit here :-) |
|
Sorry, I wasn't paying enough attention (re #1668). |
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Feb 5, 2021
ljharb
force-pushed
the
private-fields-in-in
branch
from
3ad18be
to
5349602
Compare
jridgewell
reviewed
Feb 5, 2021
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Feb 5, 2021
ljharb
force-pushed
the
private-fields-in-in
branch
from
5349602
to
e3c5cd5
Compare
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Feb 8, 2021
ljharb
force-pushed
the
private-fields-in-in
branch
from
e3c5cd5
to
d113e4f
Compare
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Mar 31, 2021
ljharb
force-pushed
the
private-fields-in-in
branch
from
d113e4f
to
d7c3c84
Compare
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Apr 27, 2021
ljharb
force-pushed
the
private-fields-in-in
branch
from
d7c3c84
to
da72c39
Compare
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
May 7, 2021
|
Thanks! Please ignore my comments then, I had a mix of a-aha and “the heck?” moment there. All good 👍 |
syg
approved these changes
Jun 28, 2021
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Jun 29, 2021
ljharb
force-pushed
the
private-fields-in-in
branch
from
791f910
to
c274ab1
Compare
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Jun 29, 2021
ljharb
force-pushed
the
private-fields-in-in
branch
from
c274ab1
to
b1911ec
Compare
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Jun 29, 2021
ljharb
force-pushed
the
private-fields-in-in
branch
from
b1911ec
to
de8ba37
Compare
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Jun 29, 2021
ljharb
force-pushed
the
private-fields-in-in
branch
from
de8ba37
to
66a3f9e
Compare
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Jun 29, 2021
ljharb
force-pushed
the
private-fields-in-in
branch
from
66a3f9e
to
f9f006c
Compare
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Jun 29, 2021
ljharb
force-pushed
the
private-fields-in-in
branch
from
f9f006c
to
a060ea8
Compare
ljharb
added
has stage 4
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Jul 14, 2021
ljharb
force-pushed
the
private-fields-in-in
branch
from
a060ea8
to
e172a6e
Compare
bakkot
approved these changes
Jul 14, 2021
bakkot
added
the
ready to merge
ljharb
force-pushed
the
private-fields-in-in
branch
from
e172a6e
to
58e9d8d
Compare
7 tasks
mathiasbynens
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on top of #1668. Please review by commit. As #1668 is updated and/or merged, I'll rebase this one.