Normative: add async iteration #1066

domenic · 2018-01-12T22:37:50Z

This supersedes @zbraniecki's #1063. The individual commits are just to show the delta from that.

One potential question for the editor is the ordering of sections within 25 (Control Abstraction Objects). I went with

Iteration
GeneratorFunction Objects
AsyncGeneratorFunction Objects
Generator Objects
AsyncGenerator Objects
Promise Objects
AsyncFunction Objects

but I can also see an argument for keeping the two new sections together, perhaps even after the AsyncFunction Objects section.

(Closes #1063)

bterlson · 2018-01-18T22:18:46Z

@domenic I think I like keeping them together at the end, personally. I'll be working on reviewing the rest of this text today/tomorrow.

bterlson · 2018-01-25T18:43:58Z

I have reviewed this from a technical basis. I have a few editorial changes that I will do once I integrate this PR (and will run anything significant by the champions as I do it).

Also, Stage 4!! 🥂

leobalter · 2018-02-08T15:11:29Z

@bterlson tc39/proposal-async-iteration#124, you might want to include this in the editorial changes you mentinoed.

spectranaut · 2018-02-08T22:22:42Z

In tc39/proposal-async-iteration#124 we recommended adding "async generator" the possible values of FunctionAllocate's parameter "functionKind".

Relatedly/if that change is accepted -- you might want to update AsyncGeneratorFunctionCreate line 2 to:

2. Let F be ! FunctionAllocate(functionPrototype, Strict, "async generator").

There seems to be no demand for alphabetization, so let's go for what makes some sense

This section *does* seem to be alphabetized

(It's debateable whether the latter is correct, but it's certainly more common.)

(There's no such thing as "an exception".)

bterlson · 2018-02-14T01:28:48Z

Alright, I think this is ready for ol' squash-n-merge. But tomorrow morning. Gotta give these commits some time to cool off first.

domenic · 2018-02-14T01:47:52Z

Wow, amazing work as always; thank you!

bterlson · 2018-02-14T02:00:48Z

@domenic I'd withhold judgement until @jmdyck fixes all my mistakes ;)

jmdyck · 2018-02-14T19:44:50Z

11 commits at domenic#2

(Putting them in a PR was probably unnecessary if you're just going to cherry-pick, but I like seeing them as a unit.)

... in 3 invocations of ForIn/OfBodyEvaluation. (I'm *pretty* sure that it has to be ~iterate~, but please check.)

(I don't think _innerResult_ is guaranteed to be set at these points, and it seems like there's more to be done with_innerReturnResult_.)

... to distinguish it from the ~normal~ value that appears in the [[Type]] field of Completion Records, and also to better contrast it with the ~async~ value.

ljharb · 2019-12-13T18:55:35Z

spec.html

@@ -16961,24 +17218,28 @@ <h1>Runtime Semantics: ForIn/OfHeadEvaluation ( _TDZnames_, _expr_, _iterationKi
            1. Return ? EnumerateObjectProperties(_obj_).
          1. Else,
            1. Assert: _iterationKind_ is ~iterate~.


#1812 suggests this line should probably have been removed in this PR?

ljharb added pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. has test262 tests labels Jan 25, 2018

adrianheine mentioned this pull request Jan 26, 2018

Add async iteration acornjs/acorn#661

Closed

bterlson added has consensus This has committee consensus. and removed pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. labels Feb 7, 2018

domenic mentioned this pull request Feb 7, 2018

One more modified function: FunctionAllocate tc39/proposal-async-iteration#124

Closed

jmdyck mentioned this pull request Feb 9, 2018

Normative: provide default prototype and realm values for CreateBuiltinFunction #1044

Merged

bterlson force-pushed the async-iter branch from b5eb106 to d853a5f Compare February 13, 2018 22:05

Zibi Braniecki and others added 16 commits February 13, 2018 15:31

Normative: Add AsyncIteration

e94a501

Add missing abstract-operations.html contents

65f2d54

Remove <ins> from headings

4fb3658

Replace AsyncFunctionAwait with Await

da2a1b5

Update GetIterator call sites

62f9921

Fix missed IteratorClose patch

f25deb0

Remove extra wrapper around new common iteration interfaces

a595be5

Fix wrong heading

0b99361

Fix misplaced well-known symbol

96cbba7

Move AsyncIteratorClose after IteratorClose

5343371

There seems to be no demand for alphabetization, so let's go for what makes some sense

Add missing change to intro of ForIn/OfHeadEvaluation

cbfa108

Move Symbol.asyncIterator

5a9326f

This section *does* seem to be alphabetized

Move Iteration control abstraction objects into that section

9da5f0b

Another small fix for AsyncGeneratorFunction section

c6d3c24

Apply "Miscellaneous Patches" everywhere

ef1435c

Editorial: fix assert missing 'async generator' alternative.

2512577

bterlson force-pushed the async-iter branch from ee5894c to 2512577 Compare February 13, 2018 23:36

Editorial: badIteratorError --> invalidIteratorError

d31a4de

jmdyck and others added 6 commits February 13, 2018 17:00

Editorial: "was not passed" -> "is not present"

4caf147

Editorial: "the this value" -> "the *this* value"

b7c261f

(It's debateable whether the latter is correct, but it's certainly more common.)

Editorial: normalize syntax of 'if' steps

3267bc1

Editorial: insert dot at end of step

c02f03c

Editorial: "*TypeError* exception" -> "*TypeError* object"

a854d4b

(There's no such thing as "an exception".)

Editorial: fix error name regression introduced by cherry-pick

201f9cd

bterlson mentioned this pull request Feb 14, 2018

Async iter editorial domenic/ecma262#1

Closed

jmdyck and others added 12 commits February 14, 2018 13:14

Editorial: use CreateBuiltinFunction()

f98cffa

Editorial: Delete extra space.

134cf5e

Editorial: fix malformed parameter name

79c0d4e

Editorial: add _iterationKind_ to ForIn/OfBodyEvaluation's preamble

83974e0

Editorial: "production" -> "Parse Node"

5340201

Editorial: put "!" before "NewPromiseCapability(%Promise%)"

57300e4

Editorial: insert missing _iterationKind_ argument

a6aed7b

... in 3 invocations of ForIn/OfBodyEvaluation. (I'm *pretty* sure that it has to be ~iterate~, but please check.)

Editorial: "let" -> "set"

4abc04a

Editorial: _FunctionBody_ -> |FunctionBody|

2a48872

Editorial: _innerResult_ -> _innerReturnResult_

f3c9c78

(I don't think _innerResult_ is guaranteed to be set at these points, and it seems like there's more to be done with_innerReturnResult_.)

Editorial: ~normal~ -> ~sync~

3e81f71

... to distinguish it from the ~normal~ value that appears in the [[Type]] field of Completion Records, and also to better contrast it with the ~async~ value.

Editorial: add assert to GetIterator

2b4e469

bterlson merged commit b564aa9 into tc39:master Feb 15, 2018

woess mentioned this pull request Feb 19, 2018

ForIn/OfBodyEvaluation: missing return if IteratorComplete #1107

Closed

TimothyGu mentioned this pull request Sep 26, 2018

Normative: Add missing return if IteratorComplete to ForIn/OfBodyEvaluation #1111

Merged

rkirsling mentioned this pull request Aug 9, 2019

Editorial: Resolved ambiguous VarScopedDeclarations for IterationStatement #1661

Closed

ljharb mentioned this pull request Dec 13, 2019

Incorrect assertion in ForIn/OfHeadEvaluation #1812

Closed

ljharb reviewed Dec 13, 2019

View reviewed changes

jmdyck mentioned this pull request Dec 31, 2019

CreateImmutableBinding called with only one argument #1824

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Normative: add async iteration #1066

Normative: add async iteration #1066

domenic commented Jan 12, 2018 •

edited by ljharb

Loading

bterlson commented Jan 18, 2018

bterlson commented Jan 25, 2018

leobalter commented Feb 8, 2018

spectranaut commented Feb 8, 2018

bterlson commented Feb 14, 2018

domenic commented Feb 14, 2018

bterlson commented Feb 14, 2018

jmdyck commented Feb 14, 2018

ljharb Dec 13, 2019

Normative: add async iteration #1066

Normative: add async iteration #1066

Conversation

domenic commented Jan 12, 2018 • edited by ljharb Loading

bterlson commented Jan 18, 2018

bterlson commented Jan 25, 2018

leobalter commented Feb 8, 2018

spectranaut commented Feb 8, 2018

bterlson commented Feb 14, 2018

domenic commented Feb 14, 2018

bterlson commented Feb 14, 2018

jmdyck commented Feb 14, 2018

ljharb Dec 13, 2019

Choose a reason for hiding this comment

domenic commented Jan 12, 2018 •

edited by ljharb

Loading