This repository has been archived by the owner on Feb 4, 2024. It is now read-only.
feat: Migrate to RxJava 3 and RxBinding 4 fixes #317 #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tbruyelle and @epool , I've prepared here migration to RxJava 3 and move sample to use RxBinding 4 that also uses RxJava 3. Tests are passing so I think this PR should be OK. This should fix #317 Thanks! |
galuszkak
changed the title
galuszkak
changed the title
epool
reviewed
Jul 10, 2020
| @@ -513,7 +488,6 @@ public void eachSubscriptionCombined_trigger_granted() { | |||
| mRxPermissions.onRequestPermissionsResult(new String[]{permission}, result); | |||
|
|
|||
| sub.assertNoErrors(); | |||
| sub.assertNotTerminated(); | |||
There was a problem hiding this comment.
Hi @epool ,
Those methods were removed in RxJava 3 from TestObservable. See here:
https://github.com/ReactiveX/RxJava/wiki/What's-different-in-3.0#test-support-methods
|
@epool answering your question on compatibility with RxJava 2 if anyone would need their Observable to be V2 not V3 they can use bridge library called RxJavaBridge which is available here: |
epool
approved these changes
Jul 11, 2020
|
Thx @epool for the review |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.