Add support for container padding#57
Add support for container padding#57tbranyen merged 1 commit intotbranyen:masterfrom stevenvachon:master
Conversation
| applyPatch (element, fragment) { | ||
| childNodes = fragment.map(childNode => { | ||
| if (!childNode.style.top) { | ||
| if (!childNode.style.top || childNode.nodeName === 'tr') { |
There was a problem hiding this comment.
Previously, the sizer element (<tr>) didn't have a top css property, which met the test's condition for exclusion. Now that it does have that property, the condition needed to be updated.
There was a problem hiding this comment.
<tr> can be changed via scrollerTagName so we should probably use that instead of hardcoding tr.
|
Very cool, looks great to me. I like how it only gets calculated during |
|
@tbranyen Any update? It'd be best if this didn't go stale. |
|
@stevenvachon only had that one last comment about the |
|
@tbranyen |
|
@stevenvachon I think from a code perspective it looks good, but we need to add some documentation around the change in the README or even an example. |
|
I don't think this PR warrants a documentation change. It now simply behaves as you'd expect it to if the scrolling container were to have padding. |
|
Published in 1.0.0 |
emand other units as they are automatically converted topxscrollTowith_itemPositions. For example, scrolling to item0would have otherwise never reached the the beginning (0px).topCSS value.