Skip to content

add 'get' alias for 'getconfig' #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 15, 2021
Merged

Conversation

wrgeorge1983
Copy link
Contributor

@wrgeorge1983 wrgeorge1983 commented Feb 3, 2021

should be added after test_refactor. may require rebase.

* separate unit tests from integration
  * unit tests have to be ran from "inside" the environment, don't require any Cisshgo or other endpoints to test against.  These import modules directly and confirm functions work as designed.  Many of them *do* require redis, however.
  * integration tests have to be ran from "outside" the environment.  These perform all their tests by sending HTTP requests to the API as an external user would.  Most of these *do* require Cisshgo or other endpoints to test against.

* rename `netpalm_testhelper` to `NetpalmTestHelper`
* `.poll_task()` now controls how long to sleep between task checks. Also supports a polling timeout (default to 30 seconds) so tasks that get stuck in 'queued' don't block test suite
* PyTest handles exceptions well, so most exception handling removed so that when exceptions do occur, PyTest can give us better information.
* create `.base_url` field
* `.poll_task_raw()` is never used and identical to `.poll_task()`.  Removed
* `.poll_task_errors()` now wraps `.poll_task()`
(cherry picked from commit c7791a6)
@wrgeorge1983 wrgeorge1983 changed the title Rename getconfig to get add 'get' alias for 'getconfig' Feb 5, 2021
@wrgeorge1983 wrgeorge1983 marked this pull request as ready for review February 5, 2021 16:42
@tbotnz tbotnz merged commit f61c368 into tbotnz:master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants