merge 2.7.x

taytzehao · Jul 8, 2021 · db4255c · db4255c
2 parents 4d2143e + 43000c1
commit db4255c
Show file tree

Hide file tree

Showing 4 changed files with 50 additions and 17 deletions.
diff --git a/changelog/improvement.8295.md → changelog/8295.improvement.md b/changelog/improvement.8295.md → changelog/8295.improvement.md
diff --git a/changelog/8711.bugfix.md b/changelog/8711.bugfix.md
@@ -0,0 +1 @@
+Fix for unnecessary retrain and duplication of folders in the model
diff --git a/poetry.lock b/poetry.lock
diff --git a/rasa/model_training.py b/rasa/model_training.py
@@ -218,11 +218,10 @@ async def _train_async_internal(
     new_fingerprint = await model.model_fingerprint(file_importer)
     old_model = model.get_latest_model(output_path)
 
-    fingerprint_comparison = model.should_retrain(
-        new_fingerprint, old_model, train_path, force_training=force_training
-    )
-
     if dry_run:
+        fingerprint_comparison = model.should_retrain(
+            new_fingerprint, old_model, train_path, force_training=force_training
+        )
         code, texts = dry_run_result(fingerprint_comparison)
         for text in texts:
             print_warning(text) if code > 0 else print_success(text)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix for unnecessary retrain and duplication of folders in the model