C++ front end fixes: prevent regression failures on windows, implement style improvements #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thk123 just send a set of stylistic comments. I want to add them to this PR, so please hold off merging. |
andreast271
force-pushed
the
c++-front-end-fixes-at-2
branch
from
11f7910 to
7118733
Compare
38 tasks
|
I implemented two of the style suggestions by @thk123 and replied to his comments. The PR is now ready to be accepted (or not) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI failures of regression tests in the cpp directory are avoided by not running tests on windows (
Function_Overloading{2,3}), or by removing system headers from regression sources (Resolver{10,11}, Template_Parameters1). I tested this on windows locally and it worked.A second commit implements style suggestions made by @smowton.