fix: multi-message notification causing application to become unresponsive #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is a new message notification, the historical message will be automatically closed.
add change file
muwoo
changed the title
amrbashir
reviewed
Aug 13, 2024
|
@amrbashir Thank you for your reply, but I have a question to ask. The message notification interaction of Windows 10 and MacOS is to remove the historical message notifications after the new message notifications are displayed. Why doesn't Windows 7 keep the same mode and use the stacking mode? |
|
The idea is to give the user a chance to see the notification because there is no notification center in Windows 7 and once it is closed, there is no way for them to see it ever again. Windows 10 & 11, they have a different behavior indeed but they save notifications in a queue and show them one by one, I am fine with implementing that instead if possible but the current PR removes the previous notification immediately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#68 When there is a new message notification, the historical message will be automatically closed.