fix: forwarding click events on macOS 27 - #341
Open
iparaskev wants to merge 1 commit into
Open
Conversation
On macos 27 the left click events are not forwared to the NSView while the status item has an NSMenu. Here this worked around by only calling setMenu after we've received the click event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macos 27 the left click events are not forwarded to the NSView while the status item has an NSMenu (I think this is because of TN3212). Here this is worked around by only calling setMenu after we've received the click event.
I've tested this on macOS 27.0 Beta (26A5378n).
Note that mouse Enter/Move/Exit events don't work on this version, there is thread for this.