Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Pin minisign to 0.7.3 to prevent issues with empty key passwords #7197

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

FabianLars
Copy link
Member

Using 0.7.5 will give me Error incorrect updater private key password: Wrong password for that key and since we want to release soon i thought pinning it would be faster than figuring out the issue (cause i have no idea what's going on lol)

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

ah shit

@FabianLars FabianLars requested a review from a team as a code owner June 14, 2023 09:22
@lucasfernog
Copy link
Member

Weird, it actually works on my end. Though jedisct1/rust-minisign@2de7792 indeed looks scary.

@FabianLars
Copy link
Member Author

maybe windows only idk - no idea how that could be possible tho.

If running cargo install in a local copy of tauri I also had to rebuild tauri-cli twice sometimes for some weird reason. -> If you run it locally you have to run cargo update to see the issue,
cargo install from git/1.3 without the frozen-lockfile flag pulled 0.7.5 automatically and repros the issue 100% consistent for me.

@lucasfernog
Copy link
Member

I can reproduce it on Windows omg :| we should file an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

2 participants