Skip to content

Conversation

@lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog lucasfernog requested review from a team June 7, 2020 19:39
@ken0x0a
Copy link

ken0x0a commented Jul 9, 2020

Is there any reason for that this is not merged for a while?

Global shortcut API is great, isn't it?

@lucasfernog
Copy link
Member Author

We need macOS support to merge this, but hotkey only supports Linux and Windows :(

@ken0x0a
Copy link

ken0x0a commented Jul 9, 2020

@lucasfernog
Copy link
Member Author

What?? How did you find this gem??? You're a genius. I'm definetely going to find some time to try it, maybe we can publish it next week. Awesome work!

@lucasfernog
Copy link
Member Author

By the way if you want to contribute, you could see if the original hotkey-rs repo would accept a PR with that code or push that to a repo and see if it works (if you have a macOS).

@ken0x0a
Copy link

ken0x0a commented Jul 9, 2020

Thank you for awesome project!!

Actually, I was thinking about it, but I quit as I've never read "C" and,
now I'm learning Rust. So it's too much for me 😊

I'm looking forward to seeing this to be merged.
And I cannot wait "Copy & Paste" feature, and using Tauri 😆

@lucasfernog
Copy link
Member Author

No problem. Enjoy the learning, it's difficult but rewarding :) copy and paste would be the next step. Ping us on Discord in case you need anything.

@lucasfernog
Copy link
Member Author

My first experiment with Soundboard's hotkey-rs fork wasn't successful, seems like it doesn't work on latest macOS version :(

@nothingismagick
Copy link
Member

Regarding copy/paste:

webview/webview#405

That will land imminently, and although it's slightly different than this concern wanted you to know about it.

@lucasfernog
Copy link
Member Author

Hmm I was thinking about writing a Rust implementation but seems like a waste of time with that feature.

@futurist
Copy link

+1 for this PR, urgently need it!

@ken0x0a
Copy link

ken0x0a commented Sep 24, 2020

I could "copy & paste" on macOS, when I register main menus for ":copy: & ":paste".

Is it possible to do "copy & paste" already on Linux & Windows?
Is webview/webview#403 work on all platform?

@lucasfernog
Copy link
Member Author

I believe WRY makes this feature possible. I tested it again and it seems like it wasn't working on macOS due to the lack of a winit window. I'll try to get it done next week.

@lucasfernog
Copy link
Member Author

I'm going to close this PR and open another one - too many conflicts :)

@lucasfernog lucasfernog deleted the feature/shortcut branch February 14, 2021 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants