-
Notifications
You must be signed in to change notification settings - Fork 751
Add notice that the restart is about pwsh not sys #3335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for tauri-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PowerShell will not pick up the new environment variables until reboot or logout (the PowerShell, not your system), | ||
however you can refresh the current session: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more in line of the old style but without the incorrect assumption
PowerShell will not pick up the new environment variables until reboot or logout (the PowerShell, not your system), | |
however you can refresh the current session: | |
PowerShell will not pick up the new environment variables until it is restarted, | |
however you can refresh the current session: |
the however
sounds a bit wrong there, so maybe something like:
PowerShell will not pick up the new environment variables until it is restarted,
or until you manually refresh the session:
or:
To make PowerShell pick up the new environment variables you can either restart it
or run this command:
i'm not too happy with any of them tbh but the PR's suggestion basically tries to correct an incorrect statement (reboot) visibly without actually fixing it if that makes sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, the first thing popped up in my head was this should be about the powershell not the system, so that's why I edited it like this, I think maybe:
Most apps don't refresh their environment variables automatically, so to let them pickup the changes, you can either restart your terminal and IDE or for your current PowerShell session, you can refresh it with
[System.Environment]::GetEnvironmentVariables("User").GetEnumerator() | % { Set-Item -Path "Env:\$($_.key)" -Value $_.value }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit long but works for me until we get an english professor to proof read our docs 😂
Description
I got confused for a second if that's asking me to restart my computer 😂
Also changed the folder selection to select the latest one in case there're multiple version of NDK installed