Skip to content

Add notice that the restart is about pwsh not sys #3335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2025

Conversation

Legend-Master
Copy link
Contributor

Description

  • What does this PR change? Give us a brief description.
  • Closes #

I got confused for a second if that's asking me to restart my computer 😂

Also changed the folder selection to select the latest one in case there're multiple version of NDK installed

@Legend-Master Legend-Master requested a review from a team as a code owner June 6, 2025 12:37
@github-project-automation github-project-automation bot moved this to 🪵 Backlog in Documentation Jun 6, 2025
Copy link

netlify bot commented Jun 6, 2025

Deploy Preview for tauri-v2 ready!

Name Link
🔨 Latest commit 2af88ce
🔍 Latest deploy log https://app.netlify.com/projects/tauri-v2/deploys/6843c0ed4c13010008bec774
😎 Deploy Preview https://deploy-preview-3335--tauri-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment on lines 359 to 360
PowerShell will not pick up the new environment variables until reboot or logout (the PowerShell, not your system),
however you can refresh the current session:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more in line of the old style but without the incorrect assumption

Suggested change
PowerShell will not pick up the new environment variables until reboot or logout (the PowerShell, not your system),
however you can refresh the current session:
PowerShell will not pick up the new environment variables until it is restarted,
however you can refresh the current session:

the however sounds a bit wrong there, so maybe something like:

PowerShell will not pick up the new environment variables until it is restarted,
or until you manually refresh the session:

or:

To make PowerShell pick up the new environment variables you can either restart it
or run this command:

i'm not too happy with any of them tbh but the PR's suggestion basically tries to correct an incorrect statement (reboot) visibly without actually fixing it if that makes sense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, the first thing popped up in my head was this should be about the powershell not the system, so that's why I edited it like this, I think maybe:

Most apps don't refresh their environment variables automatically, so to let them pickup the changes, you can either restart your terminal and IDE or for your current PowerShell session, you can refresh it with

[System.Environment]::GetEnvironmentVariables("User").GetEnumerator() | % { Set-Item -Path "Env:\$($_.key)" -Value $_.value }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit long but works for me until we get an english professor to proof read our docs 😂

@Legend-Master Legend-Master merged commit 4f94e60 into v2 Jun 7, 2025
9 checks passed
@Legend-Master Legend-Master deleted the restart-pwsh-not-system branch June 7, 2025 10:35
@github-project-automation github-project-automation bot moved this from 🪵 Backlog to ✅ Done in Documentation Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants