Skip to content

Conversation

@Legend-Master
Copy link
Contributor

Reference: #1115

Emit Event::LoopDestroyed on receiving WM_ENDSESSION message on Windows

Previously, we run the default DefSubclassProc here which will also return 0 and causing the app to terminate without a chance to save its states on Event::LoopDestroyed

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2025

Package Changes Through 4820bca

There are 1 changes which include tao with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tao 0.34.0 0.34.1

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@Legend-Master
Copy link
Contributor Author

I have no idea why the miri test is failing and it seems to fail on commits that were quite a long ago, there's no traceback or function location info either

@Legend-Master Legend-Master marked this pull request as ready for review August 3, 2025 16:17
@Legend-Master Legend-Master requested a review from a team as a code owner August 3, 2025 16:17
@Legend-Master
Copy link
Contributor Author

@lucasfernog should I merge this one? (didn't have the permission 2 days ago, wondering if you meant to delay it or let me merge it myselves)

@FabianLars
Copy link
Member

I gave you the permissions earlier today btw, welcome to the webview team 😅

@Legend-Master
Copy link
Contributor Author

@lucasfernog should I merge this one? (didn't have the permission 2 days ago, wondering if you meant to delay it or let me merge it myselves)

Merging this for now, we can always revert if that's not what you want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants