[updater] doesn't shutdown app gracefully on Windows

[Legend-Master]

This skips app clean up code, for example kill sidecar / save windows states / save store

plugins-workspace/plugins/updater/src/updater.rs

Line 589 in 99bea25

std::process::exit(0);

[Legend-Master]

We probably need to have an API like "on post exit" for it to let the app clean up first and then run the installer/updater

A quick dirty fix would be run app.exit and run updater on exit event, and make sure we're the last registered plugin...

By the way, the updater still shows a powershell window, maybe we should migrate to use ShellExecute instead

[amrbashir]

I think we just need to use https://docs.rs/tauri/2.0.0-beta.11/tauri/struct.AppHandle.html#method.cleanup_before_exit

[Legend-Master]

Totally forgot it, that should do the job

[Legend-Master]

Wait, cleanup_before_exit only cleans up tray icon and resources, it doesn't run the functions listening on Exit event, so things like other plugin's on exit cleanup will not get ran

I'll take a look tomorrow, maybe we just need to also send an Exit event

[amrbashir]

We can't send an exit event, this can only be sent by tauri.

[amrbashir]

you should use the new before_exit callback to run your own cleanup

[Legend-Master]

So how one could run other plugin's clean up functions?

[amrbashir]

I guess they will need to also expose a cleanup method that users can call

or maybe change the spec of a tauri plugin to have a cleanup hook so they run cleanup there instead of on Exit event and so tauri cleanup_befor_exit can run that hook

[Legend-Master]

I feel like the clean up hook shouldn't be on the Exit event listener, when you run cleanup_before_exit, you would expect it runs all plugin clean up functions

[Legend-Master]

I like the clean up hook idea, if we need to make it, it's better to do it before going stable