Extended support for arrays & date-time fields #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkoronkkomaki
changed the title
| max-items (get schema "maxItems") | ||
| item-schema (get schema "items") | ||
| uniqueItems (get schema "uniqueItems")] | ||
| (if (and min-items (> min-items (count data))) |
There was a problem hiding this comment.
Use cond instead of multiple nested ifs?
the do that wraps the let is unnecessary
There was a problem hiding this comment.
Changed the nested ifs into a single cond. Removed the unneeded do block.
1. Change date-time format error to use correct error type 2. Change nested ifs to use a cond 3. Remove un needed do function call
|
Requested changes done. |
tatut
added a commit
that referenced
this pull request
Sep 28, 2015
Extended support for arrays & date-time fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for:
Also included tests for each new feature.