Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the input numel issue #11

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

yuanxion
Copy link
Contributor

@yuanxion yuanxion commented Jul 28, 2023

Fix the "numel needs to be smaller than int32_t max; otherwise, please use packed_accessor64" issue.

    verts, faces = self.mc_func(level.to(get_rank()), threshold)
  File "/usr/local/lib/python3.10/dist-packages/torchmcubes/__init__.py", line 12, in marching_cubes
    return mc.mcubes_cuda(vol, thresh)
RuntimeError: numel needs to be smaller than int32_t max; otherwise, please use packed_accessor64

…e use packed_accessor64" issue

Signed-off-by: yuan.xiong <yuan.xiong@intel.com>
@yuanxion
Copy link
Contributor Author

The above issue happens when trying to run marching cubes with mcubes_cuda on large volumes input like 512^3.
And the issue will not happen when with small volumes like input 256^3.

@tatsy
Copy link
Owner

tatsy commented Aug 1, 2023

Hi, @yuanxion. Thank you very much for your PR. Excuse me, but please allow me have some more time to review the update.

Best,
Tatsuya

@tatsy tatsy merged commit 05a3fab into tatsy:master Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants