Skip to content

Conversation

@MariaSolOs
Copy link
Contributor

For consistency with the legacy configuration and to ease the migration to ESLint 9, it feels reasonable to keep the same rule name across the plugin.

Copy link
Owner

@tatethurston tatethurston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Thanks!

@MariaSolOs
Copy link
Contributor Author

Hmm the CI failure looks unrelated...

@tatethurston tatethurston merged commit f6b7eb1 into tatethurston:main Mar 15, 2025
1 of 2 checks passed
@tatethurston
Copy link
Owner

Yeah I'll take a look at the CI, thanks for the patch!

@MariaSolOs MariaSolOs deleted the rule-name branch March 15, 2025 22:31
@MariaSolOs
Copy link
Contributor Author

Thank you for the quick review and merge!
Could a release be prepared with this fix? I would like to pick up this change in a project I'm working on 😁

@tatethurston
Copy link
Owner

@MariaSolOs released https://github.com/tatethurston/eslint-plugin-react-prefer-function-component/releases/tag/v4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants