Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

angularjs_require: upgrade angular to 1.2.1 #720

Merged
merged 1 commit into from
Nov 16, 2013

Conversation

torifat
Copy link
Contributor

@torifat torifat commented Nov 15, 2013

No description provided.

"todomvc-common": "~0.1.4"
},
"devDependencies": {
"angular-mocks": "~1.2.0"
"angular-mocks": "~1.2.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You wouldn't have needed to update those. Tilde is absolutely fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I will ignore it.

@passy
Copy link
Member

passy commented Nov 15, 2013

Could you apply the trimming fix here as well?

@torifat
Copy link
Contributor Author

torifat commented Nov 15, 2013

@passy applied

@passy
Copy link
Member

passy commented Nov 15, 2013

@torifat Can you squash the commits?

@torifat
Copy link
Contributor Author

torifat commented Nov 15, 2013

@passy done.

@passy
Copy link
Member

passy commented Nov 16, 2013

Yay, thanks so much!

passy added a commit that referenced this pull request Nov 16, 2013
angularjs_require: upgrade angular to 1.2.1
@passy passy merged commit 3af7952 into tastejs:gh-pages Nov 16, 2013
gustaff-weldon pushed a commit to gustaff-weldon/todomvc that referenced this pull request Dec 23, 2013
angularjs_require: upgrade angular to 1.2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants