batman updated to use bower. about time, batman. #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 12 error path /Users/ssawchukii/dev/todomvc/labs/architecture-examples/batman/components/batman/package.json | ||
| 13 error code ENOENT | ||
| 14 error errno 34 | ||
| 15 verbose exit [ 34, true ] |
sindresorhus
added a commit
that referenced
this pull request
Apr 17, 2013
batman updated to use bower. about time, batman.
|
lgtm 👍 |
gustaff-weldon
pushed a commit
to gustaff-weldon/todomvc
that referenced
this pull request
Dec 23, 2013
batman updated to use bower. about time, batman.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#475
Batman has been updated with Bower. I also registered batman.js with Bower.
I tweaked the readme to add info on how to (get|use) coffeescript and npm to compile the code.
There was also a mini-bug in the app. While editing a todo, the keyup event was waiting for the enter key. When enter was struck, the code manually called the "toggleEditingMode" function, which was also being called by the blur() event. Instead of double-firing, I changed it to, pseudo: if (enterKey) input.blur() which allows the blur event to call the "toggleEditingMode" function as usual.
Batman!