Contributing Documentation #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hah, this is great! I almost feel we should split it out into a codestyle.md doc. wdyt? |
| var i, l, ret; | ||
| var i; | ||
| var l; | ||
| var ret; |
|
Dude, I did that, and you guys burned me for it! I'll put it back :) |
| Your JSHint code blocks must follow this style: | ||
|
|
||
| ```js | ||
| /*global define App*/ |
There was a problem hiding this comment.
Shouldn't it be /*global define, App */?
There was a problem hiding this comment.
Woops, you're right about that.
|
Definitely like the codestyle.md idea. I'll run with that! |
|
+1 for splitting, but let's keep a link to them in the same section of the contribution guidelines for some time so the links still work. |
|
Sure, of course, I think we should keep the link there forever. |
|
Created the new file, and linked to it from contributing.md |
sindresorhus
added a commit
that referenced
this pull request
Apr 12, 2013
Contributing Documentation
|
Very nice! :) |
|
Thanks! :) |
|
Thank you guys! 💃 |
gustaff-weldon
pushed a commit
to gustaff-weldon/todomvc
that referenced
this pull request
Dec 23, 2013
Contributing Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#529
I've added more style guidelines to the contributing.md. If I missed anything or overdid it, let me know, and I'll be happy to make changes.