-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributing Documentation #534
Conversation
Hah, this is great! I almost feel we should split it out into a codestyle.md doc. wdyt? |
var i, l, ret; | ||
var i; | ||
var l; | ||
var ret; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Existing is correct.
Dude, I did that, and you guys burned me for it! I'll put it back :) |
Your JSHint code blocks must follow this style: | ||
|
||
```js | ||
/*global define App*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/*global define App */
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be /*global define, App */
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops, you're right about that.
Definitely like the codestyle.md idea. I'll run with that! |
+1 for splitting, but let's keep a link to them in the same section of the contribution guidelines for some time so the links still work. |
Sure, of course, I think we should keep the link there forever. |
Created the new file, and linked to it from contributing.md |
Contributing Documentation
Very nice! :) |
Thanks! :) |
Thank you guys! 💃 |
Contributing Documentation
#529
I've added more style guidelines to the contributing.md. If I missed anything or overdid it, let me know, and I'll be happy to make changes.