homepage: fix quote links. #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
added a commit
that referenced
this pull request
Apr 12, 2013
homepage: fix quote links.
|
Hah, that's right. I remember I thought it was awesome how much work you put into such a tiny feature :D |
|
Oh, but such a valuable one. Lol. |
|
Indeed :D |
gustaff-weldon
pushed a commit
to gustaff-weldon/todomvc
that referenced
this pull request
Dec 23, 2013
homepage: fix quote links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first PR ever was adding the quote animation to the homepage. And, several months later, I caught a bug (embarrassed emoticon
:-o)The quotes from the bottom of the page weren't linking to the author's site. I patched that, and tweaked the code style a little bit.