-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emberjs routing #198
Emberjs routing #198
Conversation
Initialize controller views upon `init`.
Cleanup `Ember.CollectionView` template, on editing use a contextual view. Fix race condition issue with focusOut/insertNewline when editing last item.
…er` and `ApplicationView`. Initialize entries controller upon application creation, to be passed later as content property.
…ribute setup. TODO: Refactor this to be part of `ApplicationView` as child views.
Renders items on root path.
Most of the non-dynamic (from routing point of view) views should reside in application view.
`TodosController` will filter the content based on router's filter.
cc @tomdale |
I should mention that we also have a non RequireJS ember app that I've been working on in branch. Might be useful to keep some of this parallel work in sync so that people can easily compare the differences between them. Pardon the stupid question: is the routing in this app the native ember routing Tom and c/o were talking about a month ago? If so, it would be great to also get that into the non-RequireJS app. Will wait to see how this thread progresses in case there are learning we can share across the two apps. |
Yep, I'm aware of the current state of the non-require.js app. I will take a look and update it too to include routing support once we get the feedback for this PR. Regarding routing, yep, current implementation is natively offered by Ember. Tbh, current version I'm using is the unreleased |
Although we usually aim to use the latest stable version of projects, I'm really keen to have proper ember routing landing for TodoMVC 1.0. @stas this looks good for a merge. I'm going to double check to see if theres anything more to be done on the ember app after this so we can land that (and if anything is still waiting on the RequireJS one, land that too). Thanks! |
Hey @stas. I was wondering if you might be able to help with something related to the routing of the default/standard Ember app I'm working on in branch: We have this concept of Todo model filters (default, active, completed) where https://github.com/addyosmani/todomvc/blob/emberjs/architecture-examples/emberjs/index.html#L37 Routes: https://github.com/addyosmani/todomvc/blob/emberjs/architecture-examples/emberjs/js/router.js In many other apps what we've been doing is simply triggering a call to a function that accesses the DOM I figured that perhaps I was thinking of the problem incorrectly and instead that I should simply be perhaps checking Still getting used to the routing/state management changes so I really appreciate any help you might be able |
To be honest, I don't have an answer. Maybe just start by opening an issue. |
Emberjs routing
Hey guys,
I took some time during last days and updated a bit the ember.js + require.js app.
A lot of things changed, where most important is probably the fact that the whole app now works without any calls to the globally exposed namespace, which should simplify and improve tests (which still require my attention) a lot.
I still have some questions (hopefully somebody from Ember.js team will find some time to answer those), like:
entriesController
doesn't reflect very well the ember idiom, it would be nice if I could get some hints regarding how it can be improved (probably, just rewrite the whole localStorage model). Also because of this,connectOutlets
calls might look also unfamiliar, any suggestions are welcomeContainerView
s, some of the view templates likeapp/templates/stats.html
require scope to be specified, not sure if that's a bug or a feature, looks weirdCollectionView
? Whats the best practice?Tests to be updated soon.
Thanks.