Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vanillajs cypress test run #1902

Merged
merged 2 commits into from
Jul 2, 2018

Conversation

gj262
Copy link
Contributor

@gj262 gj262 commented Jun 29, 2018

Change localStorage access to use getItem()/setItem() API calls as required by cypress test. And store an array of todos.

Update to the latest todomvc-*

Edit is completed by blur in vanillajs.

Fixes #1901

fix cypress test dependency on localStorage API calls and array of todos format

and update to latest todomvc-*

edit is completed by blur
@samccone
Copy link
Member

samccone commented Jul 1, 2018

This looks good, but needs a rebase, thank you!

Copy link
Collaborator

@FadySamirSadek FadySamirSadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FadySamirSadek FadySamirSadek merged commit 25a9e31 into tastejs:master Jul 2, 2018
@FadySamirSadek
Copy link
Collaborator

@gj262 Thanks a lot for helping out 🎉, Would appreciate your help a lot with other issues.

@gj262 gj262 deleted the vanillajs-cypress-tests branch July 2, 2018 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants