Skip to content

Conversation

@s3rius
Copy link
Member

@s3rius s3rius commented Apr 7, 2023

This PR makes watchdog and gitignore parser dependencies optional. Now if you install taskiq it won't install reload packages by default. It makes it smaller for production use. Because these dependencies are only required for development.

@s3rius s3rius linked an issue Apr 7, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2023

Codecov Report

Merging #98 (e4a6745) into develop (e66f3aa) will decrease coverage by 3.44%.
The diff coverage is 40.35%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop      #98      +/-   ##
===========================================
- Coverage    67.62%   64.18%   -3.44%     
===========================================
  Files           37       39       +2     
  Lines          942     1022      +80     
===========================================
+ Hits           637      656      +19     
- Misses         305      366      +61     
Impacted Files Coverage Δ
taskiq/cli/watcher.py 0.00% <ø> (ø)
taskiq/cli/worker/process_manager.py 0.00% <0.00%> (ø)
taskiq/cli/worker/run.py 0.00% <0.00%> (ø)
taskiq/formatters/json_formatter.py 100.00% <ø> (ø)
taskiq/receiver/params_parser.py 96.87% <ø> (ø)
taskiq/utils.py 72.72% <25.00%> (-27.28%) ⬇️
taskiq/middlewares/prometheus_middleware.py 27.77% <27.77%> (ø)
taskiq/receiver/receiver.py 86.59% <87.50%> (ø)
taskiq/__init__.py 100.00% <100.00%> (ø)
taskiq/abc/broker.py 85.39% <100.00%> (ø)
... and 6 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Pavel Kirilin <win10@list.ru>
@s3rius s3rius force-pushed the feature/opt-reloading branch from de404f5 to e4a6745 Compare April 9, 2023 21:43
@s3rius s3rius merged commit d9a5867 into develop Apr 9, 2023
@s3rius s3rius deleted the feature/opt-reloading branch May 18, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reloading related dependencies should be optional

2 participants