Skip to content

Conversation

@s3rius
Copy link
Member

@s3rius s3rius commented Apr 7, 2023

This request fixes semaphore logic.

Previously we had a case when tasks were created and they waited for semaphore to be released. This behavior can lead to OOM even if max_async_tasks number is small.

Signed-off-by: Pavel Kirilin <win10@list.ru>
@s3rius s3rius force-pushed the feature/semaphore-fix branch from 5bde8d2 to 3250607 Compare April 7, 2023 01:28
@codecov-commenter
Copy link

Codecov Report

Merging #97 (3250607) into develop (e66f3aa) will decrease coverage by 0.86%.
The diff coverage is 72.97%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop      #97      +/-   ##
===========================================
- Coverage    67.62%   66.77%   -0.86%     
===========================================
  Files           37       38       +1     
  Lines          942      957      +15     
===========================================
+ Hits           637      639       +2     
- Misses         305      318      +13     
Impacted Files Coverage Δ
taskiq/cli/watcher.py 0.00% <ø> (ø)
taskiq/cli/worker/run.py 0.00% <0.00%> (ø)
taskiq/receiver/params_parser.py 96.87% <ø> (ø)
taskiq/utils.py 72.72% <25.00%> (-27.28%) ⬇️
taskiq/abc/broker.py 85.39% <100.00%> (ø)
taskiq/brokers/inmemory_broker.py 96.61% <100.00%> (+0.11%) ⬆️
taskiq/decor.py 88.88% <100.00%> (ø)
taskiq/kicker.py 69.69% <100.00%> (ø)
taskiq/receiver/__init__.py 100.00% <100.00%> (ø)
taskiq/receiver/receiver.py 86.59% <100.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@s3rius s3rius merged commit 626a6d7 into develop Apr 7, 2023
@s3rius s3rius deleted the feature/semaphore-fix branch April 7, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants