-
Notifications
You must be signed in to change notification settings - Fork 23
Added redis sentinel support #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bf8c50e
to
a1365a6
Compare
a1365a6
to
62c030d
Compare
@s3rius Hello Pavel! I have added redis sentinel support to the taskiq-redis driver. The changes are backward compatible, but perhaps it could have been done more simply, as, for example, in dramatiq: https://github.com/Bogdanp/dramatiq/blob/master/dramatiq/brokers/redis.py#L99. But, as I understand it, the implementation of interaction with redis-py is specifically hidden in taskiq-redis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The request looks good, actually. The only thing is serailization and a small question.
Thanks for your PR.
You are correct, users should not bother themself with details. |
b344f94
to
9900a0d
Compare
@s3rius Hello. All issues have been resolved. Can you approve the PR? And then merge it to the develop branch when you need it. |
Thank you very-very much for your work. And sorry for such a delay. Amazing work. |
No description provided.