Skip to content

Added redis sentinel support #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 11, 2024

Conversation

DABND19
Copy link
Contributor

@DABND19 DABND19 commented Apr 14, 2024

No description provided.

@DABND19 DABND19 force-pushed the feature/redis-sentinel branch from bf8c50e to a1365a6 Compare April 14, 2024 14:08
@DABND19 DABND19 force-pushed the feature/redis-sentinel branch from a1365a6 to 62c030d Compare April 14, 2024 14:16
@DABND19
Copy link
Contributor Author

DABND19 commented Apr 20, 2024

@s3rius Hello Pavel! I have added redis sentinel support to the taskiq-redis driver. The changes are backward compatible, but perhaps it could have been done more simply, as, for example, in dramatiq: https://github.com/Bogdanp/dramatiq/blob/master/dramatiq/brokers/redis.py#L99. But, as I understand it, the implementation of interaction with redis-py is specifically hidden in taskiq-redis.

Copy link
Member

@s3rius s3rius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The request looks good, actually. The only thing is serailization and a small question.

@s3rius
Copy link
Member

s3rius commented Apr 20, 2024

Thanks for your PR.

But, as I understand it, the implementation of interaction with redis-py is specifically hidden in taskiq-redis.

You are correct, users should not bother themself with details.

@DABND19 DABND19 force-pushed the feature/redis-sentinel branch from b344f94 to 9900a0d Compare April 20, 2024 10:43
@DABND19 DABND19 requested a review from s3rius April 20, 2024 15:55
@DABND19
Copy link
Contributor Author

DABND19 commented May 3, 2024

@s3rius Hello. All issues have been resolved. Can you approve the PR? And then merge it to the develop branch when you need it.

@s3rius
Copy link
Member

s3rius commented Jun 11, 2024

Thank you very-very much for your work. And sorry for such a delay.

Amazing work.

@s3rius s3rius merged commit d30f200 into taskiq-python:develop Jun 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants