Skip to content

Do not set url for BaseRedisBroker #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2023
Merged

Do not set url for BaseRedisBroker #40

merged 2 commits into from
Sep 1, 2023

Conversation

igoose1
Copy link
Contributor

@igoose1 igoose1 commented Aug 16, 2023

Closes: #39

@igoose1
Copy link
Contributor Author

igoose1 commented Aug 16, 2023

  • I've used pre-commit to run linters,
  • Tests are passing.

s3rius
s3rius requested changes Aug 28, 2023
View reviewed changes
Copy link
Member

@s3rius s3rius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. But can you please update PR according to the comment?

@s3rius s3rius changed the base branch from main to develop August 28, 2023 10:55
@igoose1
Copy link
Contributor Author

igoose1 commented Aug 29, 2023

@s3rius, fixed it!

@s3rius s3rius merged commit c02b4f5 into taskiq-python:develop Sep 1, 2023
@igoose1 igoose1 deleted the 39-explicit-url branch February 17, 2024 11:16
@igoose1 igoose1 mentioned this pull request Feb 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s3rius s3rius s3rius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Url cannot be Optional
2 participants
@igoose1 @s3rius