fix(retry-jobs): add marker when needed #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
commented
Jan 11, 2024
| @@ -264,7 +264,7 @@ describe('events', function () { | |||
| { name: 'test', data: { foo: 'baz' } }, | |||
| ]); | |||
|
|
|||
| await delay(1000); | |||
| await delay(2000); | |||
There was a problem hiding this comment.
taking the opportunity to check if there are no more drained events in this test case
| @@ -468,7 +468,7 @@ describe('queues', function () { | |||
| }); | |||
|
|
|||
| describe('when completed state is provided', () => { | |||
| it('retries all completed jobs', async () => { | |||
| it('retries all completed jobs', async function () { | |||
There was a problem hiding this comment.
this is a flaky test, but with the marker addition, it should be fixed
roggervalf
force-pushed
the
fix-retry-jobs-marker
branch
from
16285b7
to
beb63bd
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
## [5.1.3](v5.1.2...v5.1.3) (2024-01-16) ### Bug Fixes * **retry-jobs:** add marker when needed ([#2374](#2374)) ([1813d5f](1813d5f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.