[Bug]: Stacktrace with limit removes the last error stack.

[nocodehummel]

Version

5.4.5

Platform

NodeJS

What happened?

Our jobs have stackTraceLimit set, and we noticed that the error stack is not updated.

How to reproduce.

The problem is caused by an incorrect use of slice inside the Job class.

this.stacktrace.push(err.stack);
if (this.opts.stackTraceLimit) {
   this.stacktrace = this.stacktrace.slice(0, this.opts.stackTraceLimit);
}

Simple reproduction example to demonstrate the issue.

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[manast]

yeah, I see, this actually a real bug as we are pushing the new stacks and then slicing them away if the length is larger stackTraceLimit.

[roggervalf]

closing as there is a merged fix in v5.4.6

[xNest]

hey, the solution does not allow stackTraceLimit to be set to 0, is this the desired behaviour?

[nocodehummel]

@xNest how do you mean does not allow?

[xNest]

If you pass 0 with the intention of not saving a stack trace, the limit will be ignored.

if (err?.stack) {
      this.stacktrace.push(err.stack);
      if (this.opts.stackTraceLimit) {
        this.stacktrace = this.stacktrace.slice(-this.opts.stackTraceLimit);
      }
    }