Skip to content

Commit

Permalink
refactor(add-job): remove extra include (#2423)
Browse files Browse the repository at this point in the history
  • Loading branch information
roggervalf authored Feb 15, 2024
1 parent 415f389 commit d08cd59
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 6 deletions.
3 changes: 1 addition & 2 deletions src/commands/addDelayedJob-6.lua
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ local rcall = redis.call
local args = cmsgpack.unpack(ARGV[1])

local data = ARGV[2]
local opts = cmsgpack.unpack(ARGV[3])

local parentKey = args[5]
local repeatJobKey = args[9]
Expand All @@ -60,7 +59,6 @@ local parentData
--- @include "includes/handleDuplicatedJob"
--- @include "includes/isQueuePaused"
--- @include "includes/storeJob"
--- @include "includes/updateExistingJobsParent"

if parentKey ~= nil then
if rcall("EXISTS", parentKey) ~= 1 then return -5 end
Expand All @@ -71,6 +69,7 @@ end
local jobCounter = rcall("INCR", idKey)

local maxEvents = getOrSetMaxEvents(metaKey)
local opts = cmsgpack.unpack(ARGV[3])

local parentDependenciesKey = args[7]
local timestamp = args[4]
Expand Down
1 change: 0 additions & 1 deletion src/commands/addParentJob-4.lua
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ local parentData
--- @include "includes/getOrSetMaxEvents"
--- @include "includes/handleDuplicatedJob"
--- @include "includes/storeJob"
--- @include "includes/updateExistingJobsParent"

if parentKey ~= nil then
if rcall("EXISTS", parentKey) ~= 1 then return -5 end
Expand Down
1 change: 0 additions & 1 deletion src/commands/addPrioritizedJob-7.lua
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ local parentData
--- @include "includes/getOrSetMaxEvents"
--- @include "includes/handleDuplicatedJob"
--- @include "includes/isQueuePaused"
--- @include "includes/updateExistingJobsParent"

if parentKey ~= nil then
if rcall("EXISTS", parentKey) ~= 1 then return -5 end
Expand Down
1 change: 0 additions & 1 deletion src/commands/addStandardJob-7.lua
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ local parentData
--- @include "includes/getTargetQueueList"
--- @include "includes/handleDuplicatedJob"
--- @include "includes/storeJob"
--- @include "includes/updateExistingJobsParent"

if parentKey ~= nil then
if rcall("EXISTS", parentKey) ~= 1 then return -5 end
Expand Down
2 changes: 1 addition & 1 deletion src/commands/includes/handleDuplicatedJob.lua
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
local function handleDuplicatedJob(jobKey, jobId, currentParentKey, currentParent,
parentData, parentDependenciesKey, completedKey, eventsKey, maxEvents, timestamp)
local existedParentKey = rcall("HGET", jobKey, "parentKey")

if not existedParentKey then
updateExistingJobsParent(currentParentKey, currentParent, parentData,
parentDependenciesKey, completedKey, jobKey,
Expand Down

0 comments on commit d08cd59

Please sign in to comment.