fix(job): revert console warn custom job ids when they represent inte…

…gers (#2312) BREAKING CHANGE throw error when custom job ids represent integers
taskforcesh · Dec 5, 2023 · 84015ff · 84015ff
1 parent 8eee20f
commit 84015ff
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/src/classes/job.ts b/src/classes/job.ts
@@ -1141,10 +1141,7 @@ export class Job<
     }
 
     if (`${parseInt(this.id, 10)}` === this.id) {
-      //TODO: throw an error in next breaking change
-      console.warn(
-        'Custom Ids should not be integers: https://github.com/taskforcesh/bullmq/pull/1569',
-      );
+      throw new Error('Custom Ids cannot be integers');
     }
 
     if (this.opts.priority) {

diff --git a/tests/test_queue.ts b/tests/test_queue.ts
@@ -36,8 +36,7 @@ describe('queues', function () {
     await connection.quit();
   });
 
-  //TODO: restore this tests in next breaking change
-  describe.skip('.add', () => {
+  describe('.add', () => {
     describe('when jobId is provided as integer', () => {
       it('throws error', async function () {
         await expect(